Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon iOS Simulator Targets #3481

Merged

Conversation

pauldavies83
Copy link
Contributor

@pauldavies83 pauldavies83 commented Nov 1, 2021

To allow downstream projects to build iOS Simulator slices on Apple Silicon (M1) architecture, the iosSimulatorArm64() compilation target is required.

Upstream dependencies also require this change, so this PR bumps the following dependencies to latest versions...

  • uuid = 0.3.1
  • kotlinCoroutines = 1.5.2
  • kotlinx-datetime = 0.3.0

verification:allTests completed successfully locally.

Resolves #3320

@apollo-cla
Copy link

@pauldavies83: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice, thanks for the contribution!

@pauldavies83
Copy link
Contributor Author

Niiiice, thanks for the contribution!

Had this locally for ages, just been waiting for all the stars to align dependencies to update

@BoD BoD linked an issue Nov 2, 2021 that may be closed by this pull request
@martinbonnin martinbonnin merged commit eb39b2e into apollographql:dev-3.x Nov 2, 2021
@pauldavies83 pauldavies83 deleted the ios_simulator_m1_targets branch November 2, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to okio 3.0
4 participants