Update docs and migration guide after builder api changes #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Apollo Android 3.x instead uses Kotlin default arguments and exposes constructors as top-level functions. | ||
|
|
||
| For example, for `ApolloClient`: | ||
| On Apollo Android 2.x you would use the `ApolloClient.builder()` method to instantiate a new Builder. With 3.x, use the `ApolloClient.Builder()` constructor instead (notice the capital `B`). |
There was a problem hiding this comment.
Should we add a deprecated builder() for the transition?
There was a problem hiding this comment.
Absolutely! Adding this to #3410.
martinbonnin
approved these changes
Oct 18, 2021
Co-authored-by: Martin Bonnin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup of #3404.
Note: as discussed I've removed the Java snippets from the normalized cache doc, and that means we will probably need a specific "Java how-to" page 😊