Generate Optional instead of null #322
Conversation
sav007
requested review from
brianPlummer,
BenSchwab,
digitalbuddha and
marwanad
sav007
changed the title
| @@ -4,6 +4,7 @@ import com.apollographql.android.api.graphql.Mutation | |||
| import com.apollographql.android.api.graphql.Operation | |||
| import com.apollographql.android.api.graphql.Query | |||
| import com.apollographql.android.api.graphql.ResponseReader | |||
| import com.apollographql.android.api.graphql.internal.Optional | |||
There was a problem hiding this comment.
outside the scope of the PR, but I feel Optional shouldn't be in the internal package since we're exposing that API to consumers.
There was a problem hiding this comment.
maybe external then?
There was a problem hiding this comment.
that or maybe util or extension since we're making the use of Optional optional?
No preference, whatever works.
|
@marwanad could you pls review again I add new extension to our plugin to switch on/off Optional generation |
| @@ -37,7 +40,11 @@ void generateClasses(IncrementalTaskInputs inputs) { | |||
| inputs.outOfDate(new Action<InputFileDetails>() { | |||
| @Override | |||
| public void execute(InputFileDetails inputFileDetails) { | |||
| new GraphQLCompiler().write(inputFileDetails.getFile(), outputDir, customTypeMapping, hasGuavaDep); | |||
| NullableValueType nullableValueType = NullableValueType.NONE; | |||
There was a problem hiding this comment.
I think it would be better if we keep this logic part of the compiler. I feel making this class as dummy as possible and just passing all the information to the compiler would make it easier and faster to test for one (no need for a separate integration test) alongside keeping the generation logic in one place.
Might as well create a data class GraphQLCompilerArgs to wrap all the arguments and do these checks in GraphQLCompiler.write()?
Part of #290
Variables generation remains the same due to the plan of refactoring to simplify builder. So will be done in next PR.
Input object generation remains the same as they being used in serialization of request body via moshi.