Add support for @deprecated directive without any deprecation reason
#2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will fall back to 'No longuer supported' Fixes #2664
tasomaniac
approved these changes
Oct 23, 2020
sav007
reviewed
Oct 24, 2020
| @@ -80,8 +80,7 @@ internal data class ObjectType( | |||
| val type: FieldType, | |||
| val description: String, | |||
| val isOptional: Boolean, | |||
| val isDeprecated: Boolean, | |||
| val deprecationReason: String, | |||
| val deprecationReason: String?, // null if not deprecated | |||
sav007
approved these changes
Oct 24, 2020
This was referenced Oct 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecatedReason will fall back to 'No longer supported'
I also realised that we support
@deprecatedon input fields and arguments, makingapollo-androidahead of the spec :)Fixes #2664