Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document hasNext: False response case #4373

Closed
jpvajda opened this issue Sep 7, 2022 · 2 comments · Fixed by #4318
Closed

Document hasNext: False response case #4373

jpvajda opened this issue Sep 7, 2022 · 2 comments · Fixed by #4318
Assignees
@martinbonnin

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Sep 7, 2022 •
edited
Loading

Relates to apollographql/router#1687

I think it's fine to release as-is and let users debounce for now. Functionality is still there. It's just sub-optimal. Users can still call .watch(), they just get an extra event in the initial Flow.

Though we should document how handle this case in our preliminary @defer documentation
@jpvajda jpvajda mentioned this issue Sep 7, 2022
Closed
martinbonnin added a commit that referenced this issue Sep 8, 2022
@martinbonnin
update @defer to stage 2 draft and mention empty hasNext: false p…
56cc68a 
…ayloads

see #4373
@martinbonnin
Copy link
Contributor

I added a paragraph in 56cc68a. Let me know what you think

@jpvajda
Copy link
Contributor Author

jpvajda commented Sep 8, 2022

@martinbonnin This looks great thanks!

@jpvajda jpvajda linked a pull request Sep 8, 2022 that will close this issue
Changelog and doc updates for next version #4318
Merged
martinbonnin pushed a commit that referenced this issue Sep 8, 2022
@BoD @martinbonnin
Prepare changelog and doc for next version
73f9950 
Co-authored-by: Martin Bonnin <[email protected]>

add a link to the (upcoming) documentation

update date

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <[email protected]>

Update CHANGELOG.md

Co-authored-by: JV <[email protected]>

Update CHANGELOG.md

Co-authored-by: JV <[email protected]>

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <[email protected]>

trying to make yaml happy

update `@defer` to stage 2 draft and mention empty `hasNext: false` payloads

see #4373

updates from apollographql/apollo-client#10079

fix an instance of Client -> Kotlin
martinbonnin added a commit that referenced this issue Sep 8, 2022
@BoD @martinbonnin
Changelog and doc updates for next version (#4318)
72de40c 
* Prepare changelog and doc for next version

Co-authored-by: Martin Bonnin <[email protected]>

add a link to the (upcoming) documentation

update date

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <[email protected]>

Update CHANGELOG.md

Co-authored-by: JV <[email protected]>

Update CHANGELOG.md

Co-authored-by: JV <[email protected]>

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <[email protected]>

trying to make yaml happy

update `@defer` to stage 2 draft and mention empty `hasNext: false` payloads

see #4373

updates from apollographql/apollo-client#10079

fix an instance of Client -> Kotlin

* revert changes to the tests

* update CHANGELOG.md

Co-authored-by: Martin Bonnin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinbonnin martinbonnin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changelog and doc updates for next version apollographql/apollo-kotlin
3 participants
@jpvajda @martinbonnin @bignimbus