Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added correct way of default parameters #804

Merged
merged 9 commits into from
Oct 3, 2019
Merged

Added correct way of default parameters #804

merged 9 commits into from
Oct 3, 2019

Commits on Oct 2, 2019

  1. Added correct way of default parameters

    @kimdv
    kimdv committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    e8085f0 View commit details
    Browse the repository at this point in the history

  2. Remove default parameter

    @kimdv
    kimdv committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    6e4cc7f View commit details
    Browse the repository at this point in the history

  3. Remove default parameters

    @kimdv
    kimdv committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    4ef637c View commit details
    Browse the repository at this point in the history

  4. Renamed to RequestCreatorTests to match what it is doing. Added reque… 

    …st creator tests.
    @kimdv
    kimdv committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    04fd12f View commit details
    Browse the repository at this point in the history

  5. Move TestRequestCreator -> TestCustomRequestCreator

    @kimdv
    kimdv committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    8db2e1c View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. Removed fileprivate and made import testable

    @kimdv
    kimdv committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    686fb75 View commit details
    Browse the repository at this point in the history

  2. Made method public as it was missing

    @kimdv
    kimdv committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    28bfb0b View commit details
    Browse the repository at this point in the history

  3. Fixed tests

    @kimdv
    kimdv committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3036c97 View commit details
    Browse the repository at this point in the history

  4. Made tests pass. Becaue TestCustomrequestCreator uses a dictionary we… 

    … cannot rely on the order
    @kimdv
    kimdv committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    8574ab9 View commit details
    Browse the repository at this point in the history