Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output-path argument to Generate Operation Manifest #3172

Closed
wants to merge 3 commits into from

Conversation

AnthonyMDev
Copy link
Contributor

Adds --output-path and --manifest-version arguments to generate-operation-manifest CLI command.

When used, these override any operation manifest configuration in the codegen configuration. This allows us to use the command even when there is no operation manifest in the config.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 9611aab
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/64cb0d60a831590008e4f493

@BobaFetters
Copy link
Member

Like the idea of having the ability to optionally override the output path and version for manifest generation, I do think if part of the concern is that by having these options in the config json it will always generate the manifest during code generation then we should add a flag for the generate command that must be supplied in order to generate the manifest similar the to flag for fetch-schema. This way someone can just set their options in their config and be good to go vs having to explicitly not use the config json in order to avoid doing this during codegen and then needing to always provide the options in the cli command for generate-operation-manifest.

Also with these changes we need to update our codegen-cli.mdx docs to reflect the new options.

@BobaFetters
Copy link
Member

@Meschreiber changes here will likely require some updates to #3160

@Meschreiber
Copy link
Contributor

Thanks @BobaFetters !

@AnthonyMDev
Copy link
Contributor Author

Closing in favor of #3175

@AnthonyMDev AnthonyMDev closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants