Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about the store retaining the query watcher #1048

Merged
merged 3 commits into from
Feb 29, 2020

Conversation

designatednerd
Copy link
Contributor

Trying to add a bit more information about what's happening until I can get around to fixing #516.

@designatednerd
Copy link
Contributor Author

@AnthonyMDev @koenpunt @wnagrodzki would appreciate feedback on the language here

Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we're adding some docs to this. Thanks Ellen. Here's my suggestion for the wording.

Sources/Apollo/GraphQLQueryWatcher.swift Outdated Show resolved Hide resolved
@wnagrodzki
Copy link

Thank you. I think that's perfect :)

What do you think about updating this tutorial page with as well? Maybe replacing kill of with mention about cancel() method and memory leak will draw a bit more attention to this issue for newcomers.

Remember to kill off watchers when their parent object is deallocated! This is not (presently) done automatically.

@designatednerd
Copy link
Contributor Author

@wnagrodzki Yep great point.

@designatednerd designatednerd merged commit 54547fd into master Feb 29, 2020
@designatednerd designatednerd deleted the add/watcher-note branch February 29, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants