-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support for Automatic persisted queries #582
Comments
Hi, I'm actively working on this. |
Better merge #572 first, as it will need |
I hacked together really super basic support for APQ today on this branch here (It is pointing to my forked master branch though): https://github.com/SirensOfTitan/apollo-ios/tree/sirensoftitan/jun-28/apq I didn't build subscription support yet, and haven't added GET support for queries yet. I essentially just created an APQNetworkTransport that wraps another network transport and handles persisted queries. I could probably just not use My feeling after adding this is that a lot of this stuff is starting to feel a bit busy. It might be getting to the point where an ApolloLink kind-of abstraction for iOS would be really valuable. |
@SirensOfTitan a branch that supports GET method is already merged. What do you think of updating your branch to continue your work? It would be great to have persisted queries. |
I plan on working more on this today, so hopefully I’ll get to something I find PR worthy today! I’ll check back in soon.
Sent from ProtonMail Mobile
…On Sun, Jun 30, 2019 at 3:19 PM, dmandarino ***@***.***> wrote:
***@***.***(https://github.com/SirensOfTitan) a branch that supports GET method is already merged. What do you think of updating your branch to continue your work?
It would be great to have persisted queries.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#582?email_source=notifications&email_token=AABV6FTAPFYMZXK3GYHQONLP5EBMNA5CNFSM4HXW6U3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4SASQ#issuecomment-507060298), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AABV6FWIW56MUUYACPSGHM3P5EBMNANCNFSM4HXW6U3A).
|
Ops. Actually I was testing it for weeks, anyway I made a PR too #608 Please see if it's useful for you. |
This support shipped with |
To improve network performance with GraphQL, it would really be nice to have the option to enable APQ in the iOS ApolloClient. On Android this feature is already implemented like this:
The text was updated successfully, but these errors were encountered: