Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Apollo CLI version from 2.28.0 to 2.28.3 or higher #1283

Closed
thumbtack-eee opened this issue Jul 2, 2020 · 1 comment · Fixed by #1284
Closed

Update Apollo CLI version from 2.28.0 to 2.28.3 or higher #1283

thumbtack-eee opened this issue Jul 2, 2020 · 1 comment · Fixed by #1284

Comments

@thumbtack-eee
Copy link
Contributor

2.28.3 should fix the silent codegen failures on syntax errors noted in apollographql/apollo-tooling#1899.
thumbtack-eee added a commit to thumbtack-eee/apollo-ios that referenced this issue Jul 2, 2020
@thumbtack-eee
update js CLI to 2.28.3
4cd9176 
Closes apollographql#1283.
@thumbtack-eee thumbtack-eee mentioned this issue Jul 2, 2020
Merged
@thumbtack-eee
Copy link
Contributor Author

We're currently using eslint-plugin-graphql as a workaround for this bug at Thumbtack: we run the linter first, then only attempt codegen if the linter passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update js CLI to 2.28.3 thumbtack-eee/apollo-ios
1 participant
@thumbtack-eee