Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @wry/equality to improve undefined property handling. #7108

Merged

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Oct 1, 2020

See benjamn/wryware#21 for explanation and motivation. Should help with #6771, #6803, #6688, #6378, and #7081, and possibly other regressions that began with @apollo/[email protected].

See benjamn/wryware#21 for explanation and
motivation. Should help with #6771, #6803, #6688, #6378, and #7081, and
possibly other regressions that began in @apollo/[email protected].
@benjamn benjamn added this to the Post 3.0 milestone Oct 1, 2020
@benjamn benjamn requested review from hwillson and jcreighton October 1, 2020 17:59
@benjamn benjamn self-assigned this Oct 1, 2020
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks @benjamn!

@benjamn benjamn merged commit 0cf81cb into release-3.3 Oct 1, 2020
@benjamn benjamn deleted the improve-undefined-handling-for-deep-equality-checks branch October 1, 2020 18:00
benjamn added a commit that referenced this pull request Oct 1, 2020
benjamn added a commit that referenced this pull request Oct 5, 2020
This reverts commit 68f8da6, which was
inappropriately merged in PR #7118.

This change should not have been auto-merged, given [the meaning of
`^`](https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004) when the
major version is `0`. We will be updating `@wry/equality` to v0.3.0 in
`@apollo/[email protected]` (#7108, #7015), and not before then.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants