Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MutationResult API docs: include client #3370

Merged
merged 3 commits into from
May 2, 2018

Conversation

cooperka
Copy link
Contributor

Mutation docs are here; new prop copied from Query docs here.

Will be available after this PR is merged: apollographql/react-apollo#1945

/label docs

@ghost ghost added the 📝 documentation label Apr 24, 2018
@cooperka cooperka changed the title Update MutationResult API docs Update MutationResult API docs: include client Apr 24, 2018
@ghost ghost added the 📝 documentation label Apr 24, 2018
@apollo-cla
Copy link

apollo-cla commented Apr 24, 2018

Messages
📖

Please add your name and email to the AUTHORS file (optional)

Generated by 🚫 dangerJS

Copy link
Contributor

@Poincare Poincare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me but should be merged only after this has been merged.

Copy link
Contributor

@peggyrayzis peggyrayzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small edit on the wording, thanks for catching this! 😀

@stubailo stubailo merged commit 2867a6d into apollographql:master May 2, 2018
@cooperka
Copy link
Contributor Author

cooperka commented May 3, 2018

Hi @stubailo, this merge should probably be reverted as the PR it relies on is still open: apollographql/react-apollo#1945

Update: Looks like it was removed in 94ed8f7.

@hwillson
Copy link
Member

Hi @cooperka - apollographql/react-apollo#1945 has been merged, so if you're interested in creating a new PR with the changes here, I'll merge it right away. Thanks very much!

@cooperka
Copy link
Contributor Author

Thanks @hwillson! Here: #3594

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants