Support custom directives in InMemory Cache #2710
Conversation
|
@neoziro: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Generated by 🚫 dangerJS |
gregberge
force-pushed
the
support-custom-directives
branch
from
87d6548
to
59e3da4
Compare
gregberge
force-pushed
the
support-custom-directives
branch
from
59e3da4
to
ab02083
Compare
| Object.keys(directives).forEach(key => { | ||
| if (KNOWN_DIRECTIVES.indexOf(key) !== -1) return; | ||
| if (directives[key] && Object.keys(directives[key]).length) { | ||
| completeFieldName += `@${key}(${JSON.stringify(directives[key])})`; |
There was a problem hiding this comment.
Hey, how about directives arguments? Should put it in the key too?
There was a problem hiding this comment.
Actually they are! directives[key] contains arguments.
There was a problem hiding this comment.
Should the keys in JSON.stringify(directives[key]) be pre-sorted into a consistent order? Right now, they'll hash in undefined order, no?
|
@neoziro NICE! This is great! Can you fix the conflicts in the authors file and rebase on master? Happy to get this in! |
gregberge
force-pushed
the
support-custom-directives
branch
from
ab02083
to
5a5d3ec
Compare
|
@jbaxleyiii done |
|
@jbaxleyiii the CI seems broken, |
|
@neoziro odd! Can you rebase this on top of master? That should fix it and I can merge in for the next release! |
Before this change, using a custom directive corrupted the cache. It is now possible to safely use a custom directive without breaking it. Example of custom directives: https://github.com/smooth-code/graphql-directive
gregberge
force-pushed
the
support-custom-directives
branch
from
5a5d3ec
to
bfcd499
Compare
|
@jbaxleyiii done |
|
@jbaxleyiii can you merge it? |
…ographql#2710)" This reverts commit de38f3c.
Unpublished 1.1.6 due to #2710 breaking link-state
Unpublished 1.0.7 due to #2710 breaking link-state
|
@peggyrayzis do we have a solution to make it works? Also it looks like a test was missing in |
Before this change, using a custom directive corrupted the cache.
It is now possible to safely use a custom directive without breaking it.
Example of custom directives: https://github.com/smooth-code/graphql-directive
Closes #2709