Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(errors): errors are now attached to data.error #2478

Closed
wants to merge 1 commit into from

Conversation

peggyrayzis
Copy link
Contributor

When this is finished, it should fix this & all related issues in react-apollo.

One thing I want to discuss - do we want to change the property from errors to error on currentResult or just fix it here when we destructure from it in react-apollo. I'm cool w/ either option, just let me know how you want to proceed so I can fix the tests. 😀

fix(querymanager): forgot to change the property name
@muuki88
Copy link

muuki88 commented Nov 6, 2017

Thanks a lot for fixing this 🏆

From a newcomer and backend-developer perspective I'm in favor of naming the errors object errors.
At first I thought I had an implementation error on the server side until I figured out that this was an apollo bug.

@jbaxleyiii
Copy link
Contributor

@muuki88 I think we should move to networkError and graphQLErrors to be explicit. Its a convention we are using in other places and it could be backwards compat too!

@jbaxleyiii jbaxleyiii closed this Nov 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-apollo 2.0: data.error prop is undefined after server returns an error
3 participants