Conflicts #2108
Merged
Conflicts #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mistake was introduced by 5863eac when consolidating the two examples for `new ApolloClient`.
* fixed two queries in flight bug for Apollo Link * Changelog updated
* fixing the networkInterface config applying * CHANGELOG added
* Fixed single response and added subscriptions to links * remove Observable Network Interface and include subscriptions map for current interface * Subscripitons unit tests and subscribe method calls correctly to handler * Update Changelog to reflect subscriptions with Links * bumped graphql types version and include asynciterable ts library
* fix: flow: prevent RequestOptions null error * fix: flow: prevent RequestOptions null error (with test)
chore(deps): pin dependency all-contributors-cli to v4.4.0
- [Object] means array of length 1 with Object. Instead we want Array<Object> - ___* were typos. The correct values from code is __*
chore(deps): update dependency @types/node to v8.0.25
A logic error was causing the `readStoreResolver` from applying a `previousResult` to a top-level ID obtained via a custom resolver. Effectively, this bug was causing the result of any query routed through a custom resolver to fail reference equality checks, even if the result is served completely from the cache and is completely unchanged. This commit adds a regression test.
|
@jbaxleyiii, thanks for your PR! By analyzing the history of the files in this pull request, we identified @calebmer, @stubailo and @helfer to be potential reviewers. |
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## 2.0-alpha #2108 +/- ##
==========================================
Coverage 83.23% 83.23%
==========================================
Files 36 36
Lines 1879 1879
Branches 439 439
==========================================
Hits 1564 1564
Misses 308 308
Partials 7 7Continue to review full report at Codecov.
|
jbaxleyiii
pushed a commit
that referenced
this pull request
Sep 4, 2017
This reverts commit 81942a8.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch to fix conflicts on the 2.0 alpha [trivial]