WIP: replace noFetch and forceFetch with fetch policy #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubailo
reviewed
Mar 7, 2017
src/core/watchQueryOptions.ts
Outdated
| * - cache-only: return result from cache if avaiable, fail otherwise. | ||
| * - network-only: return result from network, fail if network call doesn't succeed. | ||
| */ | ||
| export type FetchPolicy = 'cache-first' | 'cache-and-network' | 'network-first' | 'cache-only' | 'network-only'; |
There was a problem hiding this comment.
Until we implement the others we should make this have only the ones we actually support, right?
There was a problem hiding this comment.
Yeah, I'm still planning to implement the others tomorrow :)
stubailo
reviewed
Mar 7, 2017
| @@ -310,9 +310,10 @@ export class ObservableQuery<T> extends Observable<ApolloQueryResult<T>> { | |||
| this.stopPolling(); | |||
| } | |||
|
|
|||
| // If forceFetch went from false to true or noFetch went from true to false | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny little steps
docs update will happen with Caleb's PR.