Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data masking tests that depended on the old profiler utils #12113

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

jerelmiller
Copy link
Member

After merging main into the release-3.12 branch, many of the data masking tests began failing since they were still using the old profiler testing utilities. This PR updates the data masking tests to use the new render stream library instead.

@jerelmiller jerelmiller requested a review from phryneas November 7, 2024 22:17
@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 7, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: bda9d2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 7, 2024

npm i https://pkg.pr.new/@apollo/client@12113

commit: bda9d2b

Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.49 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.63 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.35 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.01 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.41 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.25 KB (0%)
import { useQuery } from "dist/react/index.js" 5.22 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.63 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.02 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (0%)
import { useFragment } from "dist/react/index.js" 2.34 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.29 KB (0%)

@jerelmiller
Copy link
Member Author

I cannot figure out why the API extractor step continues to fail. I have no changes locally when I run that job, nor did the auto cleanup seem to fix it.

@jerelmiller jerelmiller added 🎭 data-masking Issues/PRs related to data masking and removed 🎭 data-masking Issues/PRs related to data masking labels Nov 8, 2024
@phryneas
Copy link
Member

phryneas commented Nov 8, 2024

@jerelmiller this might be why

 The API report is up to date: .api-reports/temp/api-report.api.md
Warning: src/masking/types.ts:21:21 - (tsdoc-html-tag-missing-greater-than) The HTML tag has invalid syntax: Expecting an attribute or ">" or "/>"
❗ API Extractor completed with 0 errors and 1 warnings

@jerelmiller
Copy link
Member Author

@phryneas oh goodness. I've combed over those logs so many times and somehow missed this every time. Thanks so much! I'll get a separate PR to address this since this is currently failing on the release-3.12 branch. Appreciate your eagle eyes!

@jerelmiller jerelmiller merged commit 7a0e1b1 into release-3.12 Nov 8, 2024
42 of 47 checks passed
@jerelmiller jerelmiller deleted the jerel/fix-test-after-merge branch November 8, 2024 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants