Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .d.cts files for cjs bundles #11905

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add .d.cts files for cjs bundles #11905

merged 3 commits into from
Jun 25, 2024

Conversation

phryneas
Copy link
Member

An experiment in the context of stuff Danny Choudhury is currently doing for Redwood - maybe as a temporary fix until we can do the major with exports.

Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 5af068a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/[email protected]

Copy link
Contributor

github-actions bot commented Jun 24, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.65 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.43 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.06 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.3 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.58 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.65 KB (0%)
import { useMutation } from "dist/react/index.js" 3.57 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.79 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.41 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.45 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.67 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.34 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.28 KB (0%)
import { useFragment } from "dist/react/index.js" 2.3 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.24 KB (0%)

@phryneas
Copy link
Member Author

/release:pr

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 394eb0d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/667966a773fd3c0008f517c3
😎 Deploy Preview https://deploy-preview-11905--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/[email protected]

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 5af068a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/667b1ce7a6f31800085926c7
😎 Deploy Preview https://deploy-preview-11905--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller
Copy link
Member

Would this fix #11895 as well by chance?

@phryneas
Copy link
Member Author

Would this fix #11895 as well by chance?

Not by itself, but then they could at least import @apollo/client/main.cjs manually and get correct types.

@phryneas phryneas marked this pull request as ready for review June 25, 2024 07:54
@phryneas
Copy link
Member Author

So, I guess we go forward with this for now, but we'll keep the right to break directly importing .cjs files in the next major, in favor of an exports field?

@github-actions github-actions bot added the auto-cleanup 🤖 label Jun 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants