Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing name to tuple member (fix TS5084) #11877

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Add missing name to tuple member (fix TS5084) #11877

merged 3 commits into from
Jun 7, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jun 5, 2024

This was brought up in https://community.apollographql.com/t/getting-error-ts5084-apollo-client-3-7-4/7267/6 - I don't know why our own type tests don't complain about it.

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 92e0bf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 5, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.69 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.47 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.57 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.64 KB (0%)
import { useMutation } from "dist/react/index.js" 3.54 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.77 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.33 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.27 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 92e0bf9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66608812fe6cc100088c8fe0
😎 Deploy Preview https://deploy-preview-11877--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for updating this.

src/react/hooks/useLoadableQuery.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the auto-cleanup 🤖 label Jun 5, 2024
@phryneas phryneas merged commit 634d91a into main Jun 7, 2024
35 checks passed
@phryneas phryneas deleted the pr/fix-TS5084 branch June 7, 2024 09:21
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
phryneas added a commit that referenced this pull request Jul 3, 2024
* Add missing name to tuple member (fix TS5084)

* Update src/react/hooks/useLoadableQuery.ts

* Clean up Prettier, Size-limit, and Api-Extractor

---------

Co-authored-by: phryneas <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants