-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds useBackgroundQuery
and useReadQuery
docs
#10880
docs: adds useBackgroundQuery
and useReadQuery
docs
#10880
Conversation
|
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
import UseBackgroundQueryResult from '../../../shared/useBackgroundQuery-result.mdx'; | ||
import UseReadQueryResult from '../../../shared/useReadQuery-result.mdx'; | ||
|
||
## `useBackgroundQuery_experimental` and `useReadQuery_experimental` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: we haven't had a hook graduate from experimental to the big leagues yet - at least since adding this page to the docs! When that happens, we should:
- remove
experimental
from named export and docs - cut + paste into
docs/source/api/react/hooks.mdx
- add a redirect in
docs/source/_redirects
, e.g./docs/react/api/react/hooks-experimental/#usefragment_experimental /docs/react/api/react/hooks/#usefragment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I think our PR to shift from alpha
-> beta
will be dropping the _experimental
suffix, so let's make this part of that planned work.
…`useReadQuery_experimental` section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a few typos and had some small suggestions for some areas. Thanks for putting this together!
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Jerel Miller <[email protected]>
Back-to-back docs PRs, thanks for another review here @jerelmiller! This one should be good to go 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 💯 🔥 🔥 🔥 . Thanks for putting this together!
Closes #10874.
Checklist: