Non-breaking React layer rewrite work

[hwillson]

We're going to publish the non-breaking React layer rewrite work as part of Apollo Client 3.6, so this issue will be used to track the non-breaking parts of apollographql/apollo-feature-requests#366. This will mostly cover:

• React 18 based compatibility and enhancements
• Ensuring better communication with the AC core (by making the React layer lighter weight)
• Revamping our test suite (leveraging renderHook)

[brainkim]

Leaving this here for me on Monday

• https://github.com/apollographql/react-apollo/blame/e1974df52021c046f92b2a475bd8336d0b77b6c1/src/Query.tsx
• Resuscribe after error in Query component react-apollo#1580
• Add SSR support for Query component react-apollo#1579

[rajington]

from apollographql/apollo-feature-requests#366

To help get some of this work out sooner (especially React 18 compatibility changes), we're going to tackle the non-breaking parts of this work in Apollo Client 3.5. Progress will be tracked here: #8419

Would this include suspense support? If so, would the goal for these changes be sometime around React 18's (unannounced) release date?

Sorry to keep inquiring about this, but the (now deprecated) fork adding suspense is what keeps us on AC2 and we really don't have to revert our async handling updates. Thanks!

[ddiachkov]

We've just migrated one of our projects to React 18, and I've been working on adding Suspense support.

Here is my working PoC:
https://github.com/hired/apollo-query-resource (not a real package yet — I've just copy-pasted code from internal monorepo):

It looks like this:

const resource = useQueryResource(query, { variables });
resource.read(); // <-- suspends

The conclusion: Suspense and Apollo actually work great together (but only on experimental branch at a moment).

[hwillson]

We're polishing up our React 18 support. We're aiming to have a new @apollo/client release candidate (for 3.6) with R18 support ready by the end of this week.

[joshlevinson]

@hwillson That's great to hear! To reiterate @rajington's question:

Would this include suspense support?

Does "our React 18 support" mean "basic compatibility with React 18" (i.e. one can update to React 18 and things won't immediately break) or "1st class support for Suspense as described in React 18's release announcement":

In React 18, you can start using Suspense for data fetching in opinionated frameworks like Relay, Next.js, Hydrogen, or Remix. Ad hoc data fetching with Suspense is technically possible, but still not recommended as a general strategy.

I understand if the answer is no, but across this issue and apollographql/apollo-feature-requests#366, folks are eager to get clarity from y'all on this!

[hwillson]

React 18 support is now available in @apollo/client@next. Thanks!