Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named fragments don't work with mutations #273

Closed
Poincare opened this issue Jun 8, 2016 · 2 comments
Closed

Named fragments don't work with mutations #273

Poincare opened this issue Jun 8, 2016 · 2 comments
Assignees

Comments

@Poincare
Copy link
Contributor

Poincare commented Jun 8, 2016

For example, something like this won't work correctly:

mutation {
  createAuthor(firstName: "John", lastName: "Smith") {
    ...authorDetails
  }
  fragment authorDetails on Author {
    firstName
    lastName
  }
}

because the mutate method within QueryManager works with the mutation OperationDefinition rather than the Document containing the mutation. Should be an easy fix - see PR #251 since that's pretty much the same thing but for queries.

@Poincare Poincare self-assigned this Jun 8, 2016
@helfer
Copy link
Contributor

helfer commented Jun 8, 2016

good catch!

@Poincare
Copy link
Contributor Author

Poincare commented Jun 9, 2016

Fixed w/ PR #274.

@Poincare Poincare closed this as completed Jun 9, 2016
jbaxleyiii pushed a commit that referenced this issue Oct 18, 2017
Add gql to the list of imports
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants