Make sure Mocha exits after tests finish/fail/timeout.

apollographql · Feb 8, 2021 · 668711a · 668711a
1 parent 53a6f7c
commit 668711a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/scripts/memory/package.json b/scripts/memory/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "scripts": {
     "preinstall": "cd ../.. && npm i && npm run build",
-    "test": "mocha --expose-gc tests.js"
+    "test": "mocha --exit --expose-gc tests.js"
   },
   "dependencies": {
     "@apollo/client": "file:../../dist",

diff --git a/scripts/memory/tests.js b/scripts/memory/tests.js
@@ -7,10 +7,16 @@ const {
 } = require("@apollo/client/core");
 
 function itAsync(message, testFn) {
+  const start = Date.now();
   let timeout;
   (function pollGC() {
     gc(); // enabled by --expose-gc
-    timeout = setTimeout(pollGC, 100);
+    // Passing --exit to mocha should cause the process to exit after
+    // tests pass/fail/timeout, but (in case that fails) we also set a
+    // hard limit of 10 seconds for GC polling.
+    if (Date.now() < start + 10000) {
+      timeout = setTimeout(pollGC, 100);
+    }
   })();
   return it(message, () => new Promise(testFn).finally(() => {
     clearTimeout(timeout);