Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fastify 5 #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for fastify 5 #297

wants to merge 1 commit into from
+446 −380

Conversation

zckrs
Copy link

@zckrs zckrs commented Oct 4, 2024

Fixes #296

@zckrs zckrs force-pushed the add-support branch 4 times, most recently from ebef2e1 to 8d07e4a Compare October 4, 2024 14:55
@marcoreni
Copy link
Contributor

@trevor-scheer Any chance of getting this reviewed? It seems like almost no changes are required and it would unlock the ability to upgrade to Fastify 5.

@wturney
Copy link

wturney commented Oct 21, 2024

Fastify 5 appears to have changed the order of their generics for at least one type.

Specifically:

FastifyReply now uses RouteGeneric as the first argument. This results in a typing issue in this project for ApolloFastifyContextFunctionArgument. I assume they did this so it matches the argument order in FastifyRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for fastify 5
3 participants
@zckrs @marcoreni @wturney