Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary sshOptions to be passed to ssh2 #120

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

steverice
Copy link
Contributor

This allows for an arbitrary sshOptions to be passed in Modem options and be used when passed to the ssh constructor to get an agent from the ssh2 library.

This is a breaking change as some previous options are no longer supported.

Effectively reverts b565f55, d2f92b2, and part of 05f4319.

This allows for an arbitrary `sshOptions` to be passed in `Modem` options and be used when passed to the `ssh` constructor to get an agent from the `ssh2` library.

This is a breaking change as some previous options are no longer supported.

Effectively reverts b565f55, d2f92b2, and part of 05f4319.
@steverice
Copy link
Contributor Author

As discussed in #119 (comment), this is a breaking change that will require a major version bump.

@HorusGoul
Copy link

Can't we keep and deprecate the old config alongside the new sshOptions config to avoid a major version bump right now? Also is there anything blocking this PR? I could probably help if it's related to development. @apocas @steverice

Thanks!

@iammathew
Copy link

Hey,
Is there anything here to do to help move this PR along? Would be willing to help out :)

@apocas
Copy link
Owner

apocas commented Dec 1, 2020

Tackling this tonight.

@apocas
Copy link
Owner

apocas commented Dec 1, 2020

Can't we keep and deprecate the old config alongside the new sshOptions config to avoid a major version bump right now? Also is there anything blocking this PR? I could probably help if it's related to development. @apocas @steverice

Thanks!

I don't see why we need to do a major bump with this. Retro-compatibility is maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants