Support SSH password authentication #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSH password authentication is quite common and with a strong password can be quite secure. Let's support it in docker-modem and dockerode.
|
👍 |
|
@apocas Thanks -- please let me know when published :) |
|
Published in v2.1.2 |
steverice
added a commit
to steverice/docker-modem
that referenced
this pull request
Apr 16, 2020
Like apocas#117, add a common SSH option supported by [ssh2](https://github.com/mscdex/ssh2#client-methods). All we need to do is pass it in the constructor.
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH password authentication is quite common and with a strong password can be quite secure. Let's support it in
docker-modemanddockerode.All that's needed to support it is to pass
opts.passwordthrough to the underlyingsshlibrary :)