Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for show-zero-points-immediately #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikaelGusse
Copy link

@mikaelGusse mikaelGusse commented Aug 16, 2024

Description

What?

Add support to rst-tools to enable the show-zero-points-immediately flag for an exercise.

Why?

Was asked by the teachers. Needs the requisite A+ pull request to function correctly A+ pr #1389

How?

Changed revealrule.py parsing

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how I feel about this syntax with a : to split the option arguments.
What do you think @murhum1 ?

Should we just have a separate option, e.g., :reveal-zero-points-immediately: that gives a warning if the :reveal-submission-feedback: option is missing?

There is a somewhat similar validation with :randomized: and :structured-randomized: options, where the build fails if both are used at the same time:

if 'randomized' in self.options:
if 'structured-randomized' in self.options:
source, line = self.state_machine.get_source_and_line(self.lineno)
raise SphinxError(
source + ": line " + str(line) +
"\nThe option 'randomized' can not be used together with the option 'structured-randomized'!"
)

@ihalaij1 ihalaij1 requested a review from murhum1 August 29, 2024 11:14
@ihalaij1 ihalaij1 assigned murhum1 and unassigned ihalaij1 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under review
Development

Successfully merging this pull request may close these issues.

3 participants