cordova-ios 4 compatibility and missing parameter in watch method added #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some "cleanup" with a better approach. |
…ash because of empty array)
…bView anymore, WKWebView support included)
apla
added a commit
that referenced
this pull request
Jan 6, 2016
cordova-ios 4 compatibility and missing parameter in watch method added
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
with these changes the plugin is now compatible with cordova-ios 4 (where some breaking changes were introduced).
Also the parameter "subscribe" was missing in the watch method (now added with default "true"). The empty array made the app crash when calling the method.
Cheers,
Thomas