Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic topic detection #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anand2718
Copy link

For issue #8

Added checks to the parser to include automatic topic detection. If automatic is set to true, possibilities are:

  • One image topic is found and set as the topic
  • More than one image topic is found, listing the image topics and causing a parser error

If the automatic argument is not specified and a topic isn't specified, a parser error is triggered.

The detection method currently is to just check if "image" is a substring of the ROS message type.

@anand2718 anand2718 linked an issue Oct 1, 2024 that may be closed by this pull request
@amarburg
Copy link
Contributor

amarburg commented Oct 1, 2024

Posted a few comments and requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Automatic topic detection
3 participants