Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Flavored Markdown dialect #53

Merged
merged 8 commits into from
Sep 11, 2020
Merged

Switch to GitHub Flavored Markdown dialect #53

merged 8 commits into from
Sep 11, 2020

Conversation

apjanke
Copy link
Owner

@apjanke apjanke commented Jul 16, 2020

This is a prospective PR for switching to GFM, to fix an issue with fenced code block formatting brought up by an email submitter.

Fixes #57.

@apjanke apjanke added the bug Something isn't working label Jul 16, 2020
@apjanke apjanke self-assigned this Jul 16, 2020
@apjanke
Copy link
Owner Author

apjanke commented Jul 19, 2020

Okay, here's something: maybe this should go into an 0.9.x patch release instead of an 0.10.0 minor release, for distribution reasons: Debian and the dev Ubuntu are on Ronn-ng 0.9.x, so they might pull in new 0.9.x versions, but probably wouldn't upgrade to a new minor version until the next distro releases. And getting fenced code blocks fixed is an important bug fix.

@apjanke
Copy link
Owner Author

apjanke commented Jul 22, 2020

I'm currently leaning towards making this fix an 0.9.2 release rather than 0.10.0; having fenced code blocks be broken is a bad enough regression that this should count as just a bugfix, and I think it'll be back-compatible.

@apjanke
Copy link
Owner Author

apjanke commented Jul 22, 2020

Another Ronn-NG user has reported #56, which looks to me like this same problem with fenced code block support being broken.

@apjanke apjanke marked this pull request as ready for review September 11, 2020 21:34
@apjanke
Copy link
Owner Author

apjanke commented Sep 11, 2020

Okay, the remaining Travis failures are just gem packaging failures. Don't know what's up with them; maybe it's a Ruby version dependency? Anyway, I think they're fine, since it's working locally for me, and at least one of them (Ruby 2.7) is passing on Travis.

Merging.

@apjanke apjanke merged commit 19d4bc6 into master Sep 11, 2020
@apjanke apjanke deleted the gfm branch September 11, 2020 23:15
@apjanke apjanke modified the milestones: 0.10.0, 0.10.1 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

code blocks not correctly render badly in roff format since v0.9.0
1 participant