-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert \(bu
to \[ci]
change
#51
Revert \(bu
to \[ci]
change
#51
Conversation
Based on reading this PR and the linked upstream issues, I think your change here is probably the right thing to do. But I'm going to have to do a little reading on troff's handling of UTF8 vs. ASCII and the bullet markers before I'll be comfortable merging it. How urgent is this for you? Unfortunately I have a lot on my plate at the day job this week. |
Not urgent at all, take your time :) |
This reverts commit e7df1f0, reversing changes made to c3fd67e. Commit was introduce as a aesthetic change when using `-Kutf8 -Tutf8`. Quoting from the issue that led to the PR: > This may seem a little strange, it's more aesthetic then anything > else. When troff is run with -Kutf8 -Tutf8 to ensure that utf8 > characters appear correctly then the bullets generated by \(bu appear as > small squares (I'm using 13pt Pragmata Pro). However, in `bundler` we're not using `-Tutf8`, but `-Tascii`, and this results in weird characters for list items as reported [here](cli-kit/cli-command#78). Since this change never made it into any `ronn` release, I think reverting it could encourage adoption of `ronn-ng` as a drop-in replacement of `ronn`. At least for us :)
a0fd429
to
bfb1f5d
Compare
I rebased this PR for you so it's ready to merge once you review it. |
Thank you! |
Can you give me the TL;DR on how to run |
Note to self: References:
|
Okay, I've read through all the linked pages and the The fact that the Merging. This will go out in the Ronn-NG 0.10.0 release, which will probably happen in the next couple weeks. If you encounter any other issues using Ronn-NG as a drop-in replacement for classic Ronn, feel free to let me know, and I'll address those too. |
Thank you! |
@apjanke First, sorry I never replied to this:
To try this against
Then the man pages in the Note that the differences created by |
Second, any news on the 0.10.0 release? |
Work has let up a bit now, so I should be able to pull in all the outstanding PRs and assemble an 0.10.0 release over this weekend; figure on seeing it Monday. |
Thanks a lot @apjanke! |
Work got me after all last weekend. This weekend... |
Just checking in here in case there's any movement? |
Sorry for the delay on this! I'm calling the current state of master as ready for the 0.10.0 release. I have tagged a |
Thanks, let me try this now! |
Everything seems almost ready now for us to migrate. All changes are avoid some unnecessary blank lines and some unnecessary escaping which I don't think cause any changes in how the final output renders. See rubygems/rubygems@b275f4e. Only issue is in -\fBbundle config\fR [list|get|set|unset] [\fIname\fR [\fIvalue\fR]]
-.
+.TS
+allbox;
+\fBbundle config\fR [list get set unset] [\fIname\fR [\fIvalue\fR]]
+.TE which make the synopsis display as empty. |
Ack. That's bad enough it should be fixed before pushing out a release. I'll look in to it. |
@apjanke any plans for new stable release? Anything I can help with? |
Hi, @simi, Yeah, I think I've got a set of changes ready to go out for an 0.10 release, which I think. will address this issue? Details and "dev journal" are in #103. Work is on the Let's go, Pikachu! 0.10 branch. Basic problem here is that I have no idea what the fuck I'm doing here. I don't really know what the Ruby 2.x to 3.x transition means, especially in terms of how downstream packagers consume Ronn-NG or express dependencies, and I'm having trouble just getting it built and running on my dev boxes. Any input or advice you have here is welcome. |
This reverts commit e7df1f0, reversing changes made to c3fd67e.
Commit was introduced as a aesthetic change when using
-Kutf8 -Tutf8
in rtomayko/ronn#71, which closed ronn issue rtomayko/ronn#70.Quoting from the issue that led to the PR:
However, in
bundler
we're not using-Tutf8
, but-Tascii
, and this results in weird characters for list items as reported here.Since this change never made it into any
ronn
release, I think reverting it could encourage adoption ofronn-ng
as a drop-in replacement ofronn
. At least for us :)