Update api-security.md #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the descriptions for using API Keys and Authorization header.
Updated the CORS header sentence (dot point 9), under Authentication and Authorization. This commit aims to resolve apigovau#10
jordanwalsh23
approved these changes
Nov 13, 2020
ghost
reviewed
Nov 23, 2020
| @@ -31,14 +31,14 @@ Depending on the security classification you may be required to establish the fo | |||
| ## Authentication and Authorization | |||
|
|
|||
| - Basic or Digest authentication **SHOULD NOT** be used. | |||
| - The `Authorization: Bearer` header **MUST** be used for authentication/authorization e.g. using a JWT token. | |||
| - The `Authorization: Bearer` header **MUST** be used for authentication/authorization e.g. using a JWT token. Authorization tokens identify a user — the person — that is using the app or site. | |||
There was a problem hiding this comment.
Not every token needs to represent a person, e.g. Client credential flow.
No need for the additional text
|
Conflicts with PR #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the descriptions for using API Keys and Authorization header.
This pull request aims to clarify the use of both API Keys and Authorization header, and is related to #26