Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRUP-789 Fix PHP notice caused by missing array key #200

Merged
merged 1 commit into from
May 23, 2019
Merged

DRUP-789 Fix PHP notice caused by missing array key #200

merged 1 commit into from
May 23, 2019

Conversation

Jaesin
Copy link
Contributor

@Jaesin Jaesin commented May 23, 2019

"obscured" array key should not be removed because \Drupal\key\Form\KeyFormBase::submitForm() expects that it exist.

Logic fix from #186.

"obscured" array key should not be removed because
\Drupal\key\Form\KeyFormBase::submitForm() expects
that it exist.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mxr576 mxr576 changed the title Fix PHP notice caused by missing array key DRUP-789 Fix PHP notice caused by missing array key May 23, 2019
@mxr576 mxr576 merged commit 4ed505e into apigee:8.x-1.x May 23, 2019
@mxr576
Copy link
Contributor

mxr576 commented May 23, 2019

@cnovak Please post-verify the CLAs, but they should be ok. What is wrong with the Googlebot? :)

@cnovak cnovak added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels May 23, 2019
@cnovak
Copy link
Collaborator

cnovak commented May 23, 2019

I thought Googlebot would disallow merge. It cannot verify when there is more than one author in a PR. Verified

@mxr576
Copy link
Contributor

mxr576 commented May 24, 2019

Meh, that is an odd limitation of the service ;S

@Jaesin Jaesin added this to the 8.x-1.0-rc5 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants