Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of AttributesProperty to ApiProduct #371

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #357

@kedarkhaire kedarkhaire added this to the 3.0.6 milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (f80f26d) to head (d1e94df).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #371      +/-   ##
============================================
+ Coverage     87.54%   87.61%   +0.06%     
  Complexity     1754     1754              
============================================
  Files           349      349              
  Lines          4601     4601              
============================================
+ Hits           4028     4031       +3     
+ Misses          573      570       -3     
Flag Coverage Δ
unittests 87.61% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Entity/Property/AttributesPropertyAwareTrait.php 66.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit a65cd86 into apigee:3.x Aug 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes support is missing from ApigeeX APi product
2 participants