Allows variables that evaluate to falsy to be returned

[rcrichton]

The current code skips particular scopes that have a variable defined when the variable is falsy. This is no good as legitimate values such as empty string and boolean 'false' are then skipped and end up being set to undefined.

I'm adding this here as this seem to be an active fork of the original. Hopefully this may be merged back at some point.

[thim81]

@rcrichton apologies for the late response, forgot to turn on notifications on my repo.

I ll review your PR more in detail and afterwards merge and release it.

[thim81]

@rcrichton Could you provide me a small example of a postman collection where this happens? That way I can add a test for it, to prevent regression in future releases

[thim81]

@rcrichton Your PR changes are now included 1.8.3 release

[rcrichton]

Thanks, it's been on my todo list to get back to this, I'm glad you were happy to merge it anyways.

[thim81]

@rcrichton feel free to still share a small example of a postman collection where the behaviour occurs, so that we can create a test for it.

[rcrichton]

I created a test postman collection.

To try this out:

Using 1.8.2, pre my PR

npx @apideck/[email protected] postman-to-k6-bug.postman_collection.json -o script.js && docker run -iv `pwd`:/home/k6 loadimpact/k6 run --http-debug=full /home/k6/script.js

Using 1.8.3, after my fix

npx @apideck/[email protected] postman-to-k6-bug.postman_collection.json -o script.js && docker run -iv `pwd`:/home/k6 loadimpact/k6 run --http-debug=full /home/k6/script.js

The collection points to an httpbin endpoint that return exactly what was sent. Notice in the 1.8.2 output in the http debug log message that what was sent is incorrect:

\"data\": \"{\\n  emptyString: 'undefined',\\n  boolean: undefined\\n}\"

Where as the 1.8.3 output is correct:

\"data\": \"{\\n  emptyString: '',\\n  boolean: false\\n}\"

[thim81]

@rcrichton Thanks for sharing the test collection and details.
I've create a follow-up item #27 for me to add this to the test suite.