-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
@LinusU Hey, thanks for the submission! I think you want to check the |
Ahhh, one line! 😆 @@ -207,6 +204,7 @@ namespace snowcrash {
TrimString(subject);
if (RegexMatch(subject, NamedResourceHeaderRegex) ||
+ RegexMatch(subject, NamedEndpointHeaderRegex) ||
RegexMatch(subject, ResourceHeaderRegex)) {
return ResourceSectionType;
} Thanks for the help! 🍻 I'm pushing a rebased version now |
also can you please add tests for edge cases like : # Endpoint 1 [GET /e1]
# Endpoint 2 [GET /e1]
# Endpoint 3 [POST /e1] ? Maybe followed by something like # Endpoint 1 [GET /e1]
# E 1 resource [/e1]
## Retrieve [GET]
## Do Something Else [POST /e1] etc. |
Sure, I'll add them now! |
Done and done, was that how you meant? |
Ahh, I read your comment in the other thread now. Do you want it to merge it all into one resource with three actions? |
@@ -156,6 +156,7 @@ | |||
'test/test-MSONTypeSectionParser.cc', | |||
'test/test-MSONUtility.cc', | |||
'test/test-MSONValueMemberParser.cc', | |||
'test/test-NamedEndpoint.cc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these test cases should be in a separate file. Please add them in test-ActionParser.cc
.
Should be good to go 👍 |
Thanks for the merge 🎉 ✌️ |
Per discussion in apiaryio/api-blueprint#196.
For some reason it keeps parsing the section as copy instead of resource. No idea why thought, would appreciate some fresh 👀 on it.