feat: add validator #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jintao Zhang <[email protected]>
starsz
reviewed
Aug 23, 2023
internal/pkg/validator/validator.go
Outdated
| return false, fmt.Errorf(errWrap, resourceType, nameOrID, err) | ||
| } | ||
| defer resp.Body.Close() | ||
| return resp.StatusCode == http.StatusOK, nil |
There was a problem hiding this comment.
@lingsamuel I think sdk can support this API.
There was a problem hiding this comment.
I think we should parse the invalid info from the response body and return as an error.
There was a problem hiding this comment.
OK, let me check the response content of the APISIX API
Signed-off-by: Jintao Zhang <[email protected]>
tao12345666333
force-pushed
the
feat-validator
branch
from
2e3f581 to
04e78d0
Compare
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
lingsamuel
approved these changes
Aug 23, 2023
bzp2010
added a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
bzp2010
pushed a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
bzp2010
added a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.