Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apisix): upstream nodes should be allowed to be null #222

Merged
merged 4 commits into from
Dec 27, 2024
Merged

fix(apisix): upstream nodes should be allowed to be null #222

merged 4 commits into from
Dec 27, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Dec 27, 2024

Description

When using service discovery, nodes may be null, so it handler needs to be somewhat fault tolerant.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 requested review from juzhiyuan and guoqqqi December 27, 2024 08:15
@bzp2010 bzp2010 marked this pull request as ready for review December 27, 2024 08:15
@juzhiyuan juzhiyuan merged commit aa53fab into main Dec 27, 2024
16 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-apisix-upstream-nodes-null branch December 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoqqqi guoqqqi guoqqqi approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzp2010 @juzhiyuan @guoqqqi