Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api7): mismatched fields in upstream mtls #202

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Nov 7, 2024

Description

API7 let the upstream mtls settings as cert and key instead of client_cert and client_key in the converter, which is not schema compliant, so fix it.

Also, cert and key do not emphasize their roles, so they need to be modified.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible: This aligns the schema so it's a fix and not backward compatible.

@bzp2010 bzp2010 added the test/api7 Trigger the API7 test on the PR label Nov 7, 2024
@bzp2010 bzp2010 requested a review from juzhiyuan November 7, 2024 04:36
@bzp2010 bzp2010 marked this pull request as ready for review November 7, 2024 04:36
@bzp2010 bzp2010 merged commit 6746b9f into main Nov 7, 2024
11 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-upstream-mtls-fields branch November 7, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/api7 Trigger the API7 test on the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants