Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-order ssl operation events #183

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: re-order ssl operation events #183

merged 1 commit into from
Sep 2, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Sep 2, 2024

Description

The current SSL deletion event will occur after creation, which can cause some unintended scenarios, such as SSL certificate conflicts.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 marked this pull request as ready for review September 2, 2024 07:02
@bzp2010 bzp2010 added the test/api7 Trigger the API7 test on the PR label Sep 2, 2024
juzhiyuan
juzhiyuan approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzp2010 bzp2010 merged commit 79edaa7 into main Sep 2, 2024
8 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-ssl-delete-event-order branch September 2, 2024 07:10
@bzp2010 bzp2010 restored the bzp/fix-ssl-delete-event-order branch September 2, 2024 07:20
@pottekkat pottekkat deleted the bzp/fix-ssl-delete-event-order branch September 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@pottekkat pottekkat Awaiting requested review from pottekkat

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

Assignees
No one assigned
Labels
test/api7 Trigger the API7 test on the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzp2010 @juzhiyuan