Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): upstream linter check either nodes or service discovery #163

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix(core): upstream linter check either nodes or service discovery #163

merged 1 commit into from
Jul 27, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Jul 26, 2024

Description

The current upstream schema lists nodes as a required field, thus preventing the use of service discovery.
Now nodes will be optional, and an additional checker will ensure that one of nodes and discovery is set.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 added the bug Something isn't working label Jul 26, 2024
@bzp2010 bzp2010 changed the title fix: upstream linter check either nodes or service discovery fix(core): upstream linter check either nodes or service discovery Jul 26, 2024
pottekkat
pottekkat approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bzp2010 bzp2010 merged commit 2467ac5 into main Jul 27, 2024
8 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-upstream-nodes-requirement branch July 27, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pottekkat pottekkat pottekkat approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzp2010 @juzhiyuan @pottekkat