-
Notifications
You must be signed in to change notification settings - Fork 29
fix: remove use of references.json chainNames field #1243
Conversation
Visit the preview URL for this PR (updated for commit 648a401): https://api3-docs--pr1243-dcroote-issue1242-eg5moqg7.web.app (expires Sun, 07 Jan 2024 19:10:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d319eb7cbe610768342d5dc1b5cd1f3aed912886 |
Your logic makes sense to me for the Airnode contract addresses. There may be another issue here with the dAPI Chain and Contracts page: https://old-docs.api3.org/dapis/reference/chains.html
I guess the data is part of what dAPIs were back then but not now. But that endpoint probably needs to go. Let me propose this idea which is somewhat laziness. Since reading dAPIs is not possible the way the old docs describe we provide a link back to the new docs Chains and Contracts page? Having said that a lot of what is in the old docs for dAPIs is legacy in that the user really needs to move on to the new docs to use dAPIs. But at the very least the Chain and Contracts page is very problematic I think. Another idea is to stop using the endpoint and create a markdown table of what was the data at the time. Probably the better solution |
Good thought- I agree it's best to refer to the new docs and I've done so in the latest commit- take a look and let me know what you think. |
63c5144
to
8f2623d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1242. Since these old docs are deprecated, I've opted for skipping the display of chains that aren't present in chains.json rather than invest in upgrading these docs to use @api3/chains.