Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dapps additions #127

Merged
merged 11 commits into from
Nov 14, 2024
Merged

/dapps additions #127

merged 11 commits into from
Nov 14, 2024

Conversation

bbenligiray
Copy link
Member

Continuing working on #97

TODO: OEV Rewards

Copy link

github-actions bot commented Nov 13, 2024

Visit the preview URL for this PR (updated for commit 33e4e4b):

https://oev-docs--pr127-dapps-additions-ck121u5p.web.app

(expires Thu, 21 Nov 2024 10:29:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of very minor comments

docs/dapps/integration/security-considerations.md Outdated Show resolved Hide resolved
docs/dapps/integration/security-considerations.md Outdated Show resolved Hide resolved

::: info ℹ️ Info

We have been providing oracle services as early as [2019](https://etherscan.io/txs?a=0x78e76126719715eddf107cd70f3a31dddf31f85a&p=1029), and were listed as the [best responding oracle](/assets/reputation-link.CxhU2iIj.png) among all Chainlink oracles by [`reputation.link`](https://www.google.com/search?q=%22reputation.link%22+chainlink) as of September 2020, which is when we published the [API3 whitepaper](https://github.com/api3dao/api3-whitepaper) and requested to be removed from Chainlink data feeds.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen this img approach, but seems to work.

bbenligiray and others added 3 commits November 14, 2024 13:28
@bbenligiray bbenligiray merged commit 2461feb into main Nov 14, 2024
3 checks passed
@bbenligiray bbenligiray deleted the dapps-additions branch November 14, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants