Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #2

Closed
wants to merge 2 commits into from
Closed

Minor changes #2

wants to merge 2 commits into from

Conversation

acenolaza
Copy link

@acenolaza acenolaza commented May 15, 2024

Nothing major since it is just a trimmed down version of StakeableVesting. Just a few minor things that can be ignored.

@bbenligiray one concern that I have is if anyone ever sends more tokens than amount from initialize() to this contract then those tokens might get locked forever, right?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@bbenligiray
Copy link
Member

Yeah but the user is explicitly told to use IrrevocableVestingFactory to deploy IrrevocableVesting and it's to be expected for the user to rek themselves if they don't follow the instructions

@bbenligiray
Copy link
Member

I pushed some of these to main and closing the PR but we can continue the discussions above

@acenolaza
Copy link
Author

Yeah but the user is explicitly told to use IrrevocableVestingFactory to deploy IrrevocableVesting and it's to be expected for the user to rek themselves if they don't follow the instructions

Yes that's true but I was thinking more of the case where the use the factory but then someone mistakenly send more funds to the contract directly in order to increase the vested amount. I know this is unlikely to happen for our use case so we can end the discussion here if you think so

@bbenligiray
Copy link
Member

Ah got it. It feels too random of a user error to handle specifically though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants