fix(deps): update dependency eslint-plugin-cypress to v4

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint-plugin-cypress	^3.6.0 -> ^4.1.0

---

Release Notes

cypress-io/eslint-plugin-cypress (eslint-plugin-cypress)

v4.1.0

Compare Source

Features

• docs: publish updated readme (2bc8d5a)

v4.0.0

Compare Source

Features

• minimum version eslint v9 (b50181a)

BREAKING CHANGES

• Support ESLint v9 and above only

Support for ESlint v7 & v8 is removed
languageOptions ecmaVersion: 2019 and sourceType: module are removed from eslint-plugin-cypress/flat config
globals is updated to 15.11.0
eslint-plugin-n is updated to 17.11.1

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[dcroote]

Not ready to merge: "minimum version eslint v9“

[Siegrift]

Do you know what ESLint recommends? Are they expecting all the repos to migrate to version 9? Afaik, there are some consumer facing changes for all users (aka we would have to migrate all repos that commons uses).

But maybe we should embrace the v9 version, given it's around for quite some time.

[dcroote]

Do you know what ESLint recommends? Are they expecting all the repos to migrate to version 9?

Yes: "ESLint v8.x reached end-of-life on 2024-10-05 and is no longer maintained. "

Afaik, there are some consumer facing changes for all users (aka we would have to migrate all repos that commons uses). But maybe we should embrace the v9 version, given it's around for quite some time.

I agree it's time to migrate as it seems mature now and v8 is EOL. I can work on migrating everything across the org 🫠