Final updates before release (#7)

* Downgrade eslint-plugin-lodash

Lodash 8.0.0 has eslint@>=9.0.0 as a peer dependency

* Add rules for unicorn changes

package.json

@@ -37,7 +37,7 @@
     "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-jest": "^28.6.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-lodash": "^8.0.0",
+    "eslint-plugin-lodash": "^7.4.0",
     "eslint-plugin-no-only-tests": "^3.1.0",
     "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.32.1",

src/universal.js

@@ -85,8 +85,18 @@ module.exports = {
 
     /* Rule overrides for "unicorn" plugin */
     'unicorn/consistent-function-scoping': 'off', // Disabling due to the rule's constraints conflicting with established patterns, especially in test suites where local helper or mocking functions are prevalent and do not necessitate exports.
+    'unicorn/import-style': [
+      'error',
+      {
+        styles: {
+          'node:path': { named: true }, // Allows import { join } from 'node:path';
+          'node:util': { default: true }, // Allows import util from 'node:util';
+        },
+      },
+    ],
     'unicorn/no-abusive-eslint-disable': 'off', // Already covered by different ruleset.
     'unicorn/no-array-callback-reference': 'error', // Explicitly turned on, because it was initially disabled and "point free" notation was enforced using "functional/prefer-tacit". That said, the point free pattern is dangerous in JS. See: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-callback-reference.md.
+    'unicorn/no-array-for-each': 'off', // We use .forEach extensively across the api3dao org and even though this can be solved with --fix and there are benefits, it will generate a lot of friction.
     'unicorn/no-array-reduce': 'off', // We are OK with using reduce occasionally, but I agree with the author that the code using reduce can easily get complex.
     'unicorn/no-nested-ternary': 'off', // This rule is smarter than the standard ESLint rule, but conflicts with prettier so it needs to be turned off. Nested ternaries are very unreadable so it's OK if all of them are flagged.
     'unicorn/no-null': 'off', // We use both null and undefined for representing three state objects. We could use a string union instead, but using combination of null and undefined is less verbose.