Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #395
What does this change?
go()
usages to pass a function that returns a promise (instead of just the promise)goEncodeEvmScript()
function when calling thefail()
function:How did you action this task?
W.r.t. the type errors in the
goEncodeEvmScript()
, instead of passing theEncodedEvmScriptError
type argument to thefail()
function for each call, I let the type be the broaderError
, and usedinstanceof
when using the error when validating the proposal form: