Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinator ID #62

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add coordinator ID #62

merged 2 commits into from
Nov 2, 2023

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Nov 2, 2023

Closes #45

Rationale

We can use the new commons API logger.runWithContext where you specify metadata that is logged with every log message during the execution of the function.

To verify it works, you can use the e2e tests with logs turned off to see the metadata is indeed logged with every log message:

LOGGER_ENABLED=true LOG_LEVEL=debug pnpm run test update

@Siegrift Siegrift self-assigned this Nov 2, 2023
Copy link
Contributor

@vponline vponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🚀

@Siegrift Siegrift merged commit c566f86 into main Nov 2, 2023
4 checks passed
@Siegrift Siegrift deleted the coordinator-id branch November 2, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an update feed loop coordinator ID
2 participants