Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp dapidataregistry #60

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Conversation

vponline
Copy link
Contributor

Closes #57

@vponline vponline changed the base branch from main to immer-state October 31, 2023 14:27
@@ -13,6 +13,7 @@ export interface State {
dataFetcherInterval?: NodeJS.Timeout;
gasPriceStore: Record<string, Record<string, GasState>>;
signedApiStore: Record<AirnodeAddress, Record<TemplateId, LocalSignedData>>;
signedApiUrlStore: Record<string, Record<AirnodeAddress, string>>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved these to be available in the state, so they chould be stored here when batches are fetched. Let me know if you prefer something else, though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Base automatically changed from immer-state to main November 2, 2023 10:45
@vponline vponline merged commit c336ea7 into main Nov 2, 2023
4 checks passed
@vponline vponline deleted the remove-temp-dapidataregistry branch November 2, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove __Temporary__DapiDataRegistry
2 participants