Add DapiDataRegistry and use it to fetch active dAPIs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Oct 26, 2023
| .eslintcache | ||
|
|
||
| # Hardhat files |
There was a problem hiding this comment.
These were generated by hardhat --init. I am not sure if all of them are needed, but it's better to keep them all.
Siegrift
force-pushed
the
add-contract
branch
from
66756e9
to
01bf002
Compare
|
FYI we're still messing with the interface |
aquarat
approved these changes
Oct 27, 2023
Siegrift
force-pushed
the
create-data-feed-update-loop
branch
from
8ae1670
to
e19a094
Compare
I know. The solution is temporary but the current interface is better than the statically mocked data we have in the past. I don't see issues with updating the logic when the contract changes. |
Siegrift
force-pushed
the
create-data-feed-update-loop
branch
3 times, most recently
from
dec8cc1
to
dd44ad4
Compare
Siegrift
force-pushed
the
add-contract
branch
from
469e82d
to
7c23c2c
Compare
Siegrift
force-pushed
the
add-contract
branch
from
2c561bc
to
8671916
Compare
Siegrift
force-pushed
the
add-contract
branch
from
a5784f7
to
8ba0435
Compare
Siegrift
force-pushed
the
add-contract
branch
from
62e686d
to
fc4c243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Rationale
Because the contract is still in a PR, I've added a branch dependency and setup hardhat to build Typechain types and factories. These are then used in the actual implementation.
You need to run
pnpm i && pnpm run buildto install missing dependencies and build the Typechain artifacts.